Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tests which require network access #144

Merged
merged 8 commits into from
Jun 17, 2024
Merged

Conversation

TomNicholas
Copy link
Collaborator

@TomNicholas TomNicholas commented Jun 17, 2024

Implements @scottyhq's suggestion in #143 (comment).

Makes the test suite run considerably faster locally by default because you don't have to wait for the tests that access S3 to complete.

  • Closes #xxxx
  • Tests added
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst

@TomNicholas
Copy link
Collaborator Author

This now works, the test that fails is the hypothesis test I added in #139.

@TomNicholas TomNicholas merged commit a3039f5 into main Jun 17, 2024
1 of 4 checks passed
@TomNicholas TomNicholas deleted the mark_network_tests branch June 17, 2024 21:10
@TomNicholas
Copy link
Collaborator Author

Actually this appears to have broken the ability to run tests using pytest - I get an error ValueError: no option named 'run_network_tests'.

I can still run the tests if I specify the directory to run from, i.e. pytest -vv ./virtualizarr works. I have no idea why because I can't see what's different about this setup compared to xarray, which doesn't have this problem 😬

@TomNicholas
Copy link
Collaborator Author

Realized the problem is here likely that conftest.py should be in the root directory...

@TomNicholas
Copy link
Collaborator Author

(yeah 4d13b35 fixed it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant