Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use magic bytes to identify file formats #143

Merged
merged 9 commits into from
Jun 26, 2024
Merged

Use magic bytes to identify file formats #143

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f55a19
add more common file suffixes
scottyhq Jun 14, 2024
d8445b0
determine format based on magic bytes
scottyhq Jun 14, 2024
49f089c
Merge branch 'main' into patch-1
scottyhq Jun 25, 2024
056a583
add release note
scottyhq Jun 25, 2024
68f640c
update docstring, keep netCDF4 alias
scottyhq Jun 25, 2024
a9961b6
small contributing section, update env
scottyhq Jun 25, 2024
ca1851e
add tests
scottyhq Jun 25, 2024
f8bbc6b
ruff
scottyhq Jun 25, 2024
928efd9
disable tif,fits,hdf5 examples for now
scottyhq Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ci/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ channels:
- conda-forge
- nodefaults
dependencies:
- astropy # for FITS
- h5netcdf
- h5py
- hdf5
Expand All @@ -15,7 +14,6 @@ dependencies:
- ujson
- packaging
- universal_pathlib
- tiffile # for TIFF
# Testing
- codecov
- pre-commit
Expand Down
8 changes: 5 additions & 3 deletions virtualizarr/tests/test_xarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,11 @@ def test_read_from_url(self):
"netcdf3": "https://github.com/pydata/xarray-data/raw/master/air_temperature.nc",
"netcdf4": "https://github.com/pydata/xarray-data/raw/master/ROMS_example.nc",
"hdf4": "https://github.com/corteva/rioxarray/raw/master/test/test_data/input/MOD09GA.A2008296.h14v17.006.2015181011753.hdf",
"hdf5": "https://github.com/fsspec/kerchunk/raw/main/kerchunk/tests/NEONDSTowerTemperatureData.hdf5",
"tiff": "https://github.com/fsspec/kerchunk/raw/main/kerchunk/tests/lcmap_tiny_cog_2020.tif",
"fits": "https://fits.gsfc.nasa.gov/samples/WFPC2u5780205r_c0fx.fits",
# https://github.com/zarr-developers/VirtualiZarr/issues/159
# "hdf5": "https://github.com/fsspec/kerchunk/raw/main/kerchunk/tests/NEONDSTowerTemperatureData.hdf5",
# https://github.com/zarr-developers/VirtualiZarr/issues/160
# "tiff": "https://github.com/fsspec/kerchunk/raw/main/kerchunk/tests/lcmap_tiny_cog_2020.tif",
# "fits": "https://fits.gsfc.nasa.gov/samples/WFPC2u5780205r_c0fx.fits",
Comment on lines +319 to +323
Copy link
Contributor Author

@scottyhq scottyhq Jun 25, 2024 •
edited by TomNicholas
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting these for now, but thought I'd leave them to track #159 and #160

"jpg": "https://github.com/rasterio/rasterio/raw/main/tests/data/389225main_sw_1965_1024.jpg",
}

Expand Down
Loading