Sequence: New sequence ascan dialog #5945
Open
+228
−483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Bennetts <[email protected]>
psiinon
force-pushed
the
sequence/gui
branch
from
3db7ca9
to
6df66a5
Compare
kingthorin
reviewed
Nov 25, 2024
Comment on lines
+34
to
+39
| this.addActionListener( | ||
| e -> { | ||
| SequenceAscanDialog dialog = | ||
| new SequenceAscanDialog(ext, View.getSingleton().getMainFrame()); | ||
| dialog.setVisible(true); | ||
| }); |
There was a problem hiding this comment.
Since this is creating a new dialog each time, does it also need a dispose on close bit so that it isn't leaking memory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a new Sequence Active Scan dialog.
Remove the old 'Sequence' dialog from the Active Scan dialog - it makes much less sense now.
Related Issues
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.