custompayloads: SAST Fixes (SonarLint), Options panel help, & drop ID #5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
force-pushed
the
custom-payloads-promo
branch
2 times, most recently
from
a09983f
to
6af463c
Compare
psiinon
reviewed
Oct 28, 2024
.../main/javahelp/org/zaproxy/zap/extension/custompayloads/resources/help/contents/options.html
Outdated
Show resolved
Hide resolved
psiinon
reviewed
Oct 28, 2024
.../main/javahelp/org/zaproxy/zap/extension/custompayloads/resources/help/contents/options.html
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
custom-payloads-promo
branch
from
6af463c
to
bbc4498
Compare
kingthorin
commented
Oct 28, 2024
...n/java/org/zaproxy/zap/extension/custompayloads/CustomPayloadsMultipleOptionsTablePanel.java
Show resolved
Hide resolved
kingthorin
force-pushed
the
custom-payloads-promo
branch
4 times, most recently
from
e1ca808
to
07bf6e3
Compare
thc202
reviewed
Oct 28, 2024
...n/java/org/zaproxy/zap/extension/custompayloads/CustomPayloadsMultipleOptionsTablePanel.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
custom-payloads-promo
branch
from
07bf6e3
to
8f07845
Compare
|
I will go through the supporting rules/add-ons and ensure the related category strings are documented clearly. (In a separate PR.) |
6 tasks
kingthorin
force-pushed
the
custom-payloads-promo
branch
2 times, most recently
from
8adde25
to
198e62e
Compare
|
If the ID does not serve any purpose(?) we should completely remove it instead of just removing the column. |
|
I didn't dig into it. I just figured it didn't need to waste screen space in that one view. Can we leave removal for another PR? (After checking and discussing.) |
|
I did. |
|
Okay 😀 I'll drop it. |
kingthorin
added
the
waiting-for:pr-author
- AbstractColumnDialog > Use List interface vs ArrayList. - Column > Reduce visibility. - CustomPayload > Remove ID and related handling. - CustomPayloadColumns > Add private constructor to hide implicit one. Remove ID and related handling. - CustomPayloadMultipleOptionsTableModel > Use List interface vs ArrayList for params. Remove ID and related handling. - CustomPayloadsCategoryColumn > Make getExtension static. - CustomPayloadsMultipleOptionsTablePanel > Make showDialog static. Remove ID and related handling. - CustomPayloadsParam > Remove ID and related handling. - EditableColumn > Reduce visibility. - EditableSelectColumn > Reduce visibility, adjust method naming to proper Java camelCase. - CustomPayloadsApiUnitTest > Remove unused param API.RequestType, and pointless declared throw on shouldHavePrefix. - Messages.properties > Remove no longer needed ID key value pair. - CHANGELOG > Already has a maint note, added a note about the Options panel help button, and one about ID. - CustomPayloadsOptionsPanel > Added overridden getHelpIndex method. - Help files > Updated to include more detailed info about the functionality. Signed-off-by: kingthorin <[email protected]>
kingthorin
force-pushed
the
custom-payloads-promo
branch
from
198e62e
to
543e76b
Compare
kingthorin
removed
the
waiting-for:pr-author
kingthorin
changed the title
|
Now with ID column removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Issues
N/A
Checklist
./gradlew spotlessApplyfor code formatting