Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more regexs cases for different devices/email providers #32

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

iamshwin
Copy link

Also improved code formatting.

@iamshwin iamshwin changed the title Added more regexs cases for different devices/email provides Added more regexs cases for different devices/email providers Oct 30, 2018
@roycehaynes
Copy link
Contributor

Heyo @iamshwin! Thanks for contributing. A couple things:

1/ I don't see new tests that verify your regex solves the use cases you're trying to solve for.

2/ Also, I don't think the code formatting is a significant improvement. However, I do think changes can be made. Can you separate the two major changes (1) regex change made (include tests) and (2) the formatting into two PRs? The latter we can discuss and determine a cleaner way to perhaps auto-format code to some standard.

@roycehaynes roycehaynes self-requested a review November 1, 2018 15:55
Copy link
Contributor

@roycehaynes roycehaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamshwin See comments in PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants