Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): optimize triggering of gpu workflows #1325

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Jun 28, 2024

No description provided.

@soonum soonum added the ci label Jun 28, 2024
@soonum soonum self-assigned this Jun 28, 2024
@cla-bot cla-bot bot added the cla-signed label Jun 28, 2024
@zama-bot zama-bot removed the approved label Jun 28, 2024
@soonum soonum requested a review from agnesLeroy June 28, 2024 16:03
@soonum soonum force-pushed the dt/ci/gpu_on_approval branch 6 times, most recently from 0d3a8da to aa92adc Compare July 1, 2024 09:11
@soonum soonum added approved and removed approved labels Jul 1, 2024
@IceTDrinker
Copy link
Member

I saw a weird WASM test failure, it did not quite look like a flaky though

@IceTDrinker
Copy link
Member

is this ready soon ? I see the cuda backend tests failed still with a CUDA out of memory error, so I'm guessing test threads is still too large ?

@IceTDrinker
Copy link
Member

also needs a rebase for the wasm fix if needed

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if tests run to completion for GPU

@soonum soonum merged commit cd32972 into main Jul 9, 2024
57 of 59 checks passed
@soonum soonum deleted the dt/ci/gpu_on_approval branch July 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants