Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hlapi): remove Wop #1316

Merged
merged 3 commits into from
Jul 26, 2024
Merged

refactor(hlapi): remove Wop #1316

merged 3 commits into from
Jul 26, 2024

Conversation

mayeul-zama
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 27, 2024
@IceTDrinker
Copy link
Member

did you remove the wopbs key from the HL Server key ?

@mayeul-zama mayeul-zama changed the title refactor(hlapi): IntegerConfig does not have refactor(hlapi): remove Wop Jun 27, 2024
@mayeul-zama mayeul-zama force-pushed the mz/refacto_wop_params branch 3 times, most recently from af66c12 to 9b57b5e Compare July 4, 2024 12:12
@mayeul-zama mayeul-zama force-pushed the mz/refacto_wop_params branch 2 times, most recently from 3e9b244 to 03e7a4a Compare July 5, 2024 09:16
tmontaigu
tmontaigu reviewed Jul 24, 2024
View reviewed changes
tfhe/src/integer/server_key/radix/mod.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix/mod.rs Outdated Show resolved Hide resolved
tfhe/src/integer/server_key/radix/mod.rs Outdated Show resolved Hide resolved
tfhe/src/high_level_api/integers/unsigned/base.rs Outdated Show resolved Hide resolved
IceTDrinker
IceTDrinker reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add a parameterized test in integer to be sure everything is good for other parameter sets ?

IceTDrinker
IceTDrinker approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@zama-bot zama-bot removed the approved label Jul 26, 2024
@IceTDrinker
Copy link
Member

Thanks no need to re run the CI

@mayeul-zama mayeul-zama merged commit 8748d1c into main Jul 26, 2024
32 checks passed
@mayeul-zama mayeul-zama deleted the mz/refacto_wop_params branch July 26, 2024 10:03
@tmontaigu
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmontaigu tmontaigu tmontaigu left review comments

@IceTDrinker IceTDrinker IceTDrinker approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayeul-zama @IceTDrinker @tmontaigu @zama-bot