Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend-python): bit extract avoid extra reinterpret_precision #920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(frontend-python): bit extract avoid extra reinterpret_precision #920

wants to merge 1 commit into from

Conversation

rudy-6-4
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 28, 2024
BourgerieQuentin
BourgerieQuentin requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be (also?) a folder in compiler?

@rudy-6-4
Copy link
Contributor Author

It should be (also?) a folder in compiler?

Yes but not in this PR. But what would be the goal ?
The compiler/optimizer don't care about the extra operator, and it's remove at runtime.

The goal of this PR is to make bit extract code easier to read and assert in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BourgerieQuentin BourgerieQuentin BourgerieQuentin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rudy-6-4 @BourgerieQuentin