fix comparing stream annotations and improve unit test #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The annotation comparison for streams was not ready yet, for comparing new annotations. Only the current ones were copied to
desiredAnnotations. This was not caught because unit test compared either different streams with different specs, and we did not compare the full reason string. By extending the latter, tests started failing.After fixing the annotation comparison the stream generator function started failing because the current code did not set the resource annotation when they were missing before. Only when a value could be found for comparison (which is impossible when setting the annotation does not work, of course 🤪 )
I refactored the code and created a new pass by reference function
setResourceAnnotationso that the FES generation code remains readable.