-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: adding configurable parameter for custom role label in multiple resources #2802
Draft
idanovinda
wants to merge
13
commits into
master
Choose a base branch
from
patroni-4-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idanovinda
added
the
major
Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
label
Nov 19, 2024
|
hughcapet
reviewed
Nov 28, 2024
idanovinda
changed the title
Integrate Spilo image with Patroni version 4
Feat: adding configurable parameter for custom role label in multiple resources
Dec 6, 2024
The PR is still WIP -- migration procedure needs to be implemented. See https://patroni.readthedocs.io/en/latest/kubernetes.html#customize-role-label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
major
Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Spilo with Patroni 4.x integration: zalando/spilo#1050
This PR enhances operator to support Patroni 4.x while retaining compatibility with existing clusters by making the new role label configurable. The role terminology has changed from "master" to "primary". By default, Spilo will use the same value as before. But to allow flexibility in label configurations, we need to ensure that the role label are configurable.
This is achieved by adding configurable parameters:
pod_leader_label_value
: default is set to "master"