-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DeleteAll methods to keyring #112
Merged
mikkeloscar
merged 3 commits into
zalando:master
from
avallete:avallete/feat-add-delete-all
Sep 23, 2024
Merged
feat: add DeleteAll methods to keyring #112
mikkeloscar
merged 3 commits into
zalando:master
from
avallete:avallete/feat-add-delete-all
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@avallete please sign-off all commits to fix DCO check, thanks! |
szuecs
added
the
major
moderate risk, for example new API, small changes that have no risk
label
Sep 10, 2024
Signed-off-by: avallete <[email protected]>
Signed-off-by: avallete <[email protected]>
avallete
force-pushed
the
avallete/feat-add-delete-all
branch
from
September 10, 2024 21:00
3ad9698
to
18c3ffd
Compare
Signed-off-by: avallete <[email protected]>
👍 |
It will likely take some time until @mikkeloscar is back, max one month, FYI. |
👍 |
Hey @mikkeloscar Sorry to dig this one up, but I wonder if there is a release of the package including this feature is scheduled and when should it come around. So I can get myself a reminder and upgrade to it in our codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible implementation of #111