Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webmanifest for wider compatibility #4371

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

zerebos
Copy link
Collaborator

@zerebos zerebos commented Nov 1, 2023

Partially fixes #920, just does not enable offline usage.

@zerebos
Copy link
Collaborator Author

zerebos commented Nov 2, 2023

By the way, let me know if you want me to work on offline usage for PWA, after toying around with it some is may be mostly possible.

@zadam zadam merged commit 4db0427 into zadam:master Nov 3, 2023
2 checks passed
@zadam
Copy link
Owner

zadam commented Nov 3, 2023

By the way, let me know if you want me to work on offline usage for PWA, after toying around with it some is may be mostly possible.

Sure, although I'm curious what that "mostly" means :-)

@zerebos
Copy link
Collaborator Author

zerebos commented Nov 3, 2023

Some caveats would be:

  1. If the user goes offline there would be no way for them to get/open existing notes that have not already been cached in some way. (i.e. viewing the note when they were online)
  2. Any functionality not already cached like the different language extensions for codemirror will be lost during offline mode.
  3. Users would not be able to create new notes

Number 1 can't really be worked around without explicitly attempting to cache every single note on first install, which is technically possible but can also lead to a lot of stale information.

Number 2 can be worked around by pre-caching all the potential resources like that though it is a bit of a pain to do.

Number 3 can't be worked around without actual changes to Trilium.

So either way I think a network-first approach is the right one for Trilium, and combine this with some updates to the mobile interface (#3975, #4335) I think that would alleviate a lot of the calls for a "proper" mobile app.

@zerebos zerebos deleted the pwa-manifest branch November 3, 2023 17:01
@zadam
Copy link
Owner

zadam commented Nov 3, 2023

So either way I think a network-first approach is the right one for Trilium

Agreed.

@dahamsta
Copy link

dahamsta commented Nov 4, 2023

Thanks for this. Would I be right in saying that this wasn't rolled into 0.61.12?

@zerebos
Copy link
Collaborator Author

zerebos commented Nov 4, 2023

This was merged into main which will become 0.62

@dahamsta
Copy link

dahamsta commented Nov 4, 2023

Great, thanks, I'll test as soon as I get it.

@zerebos
Copy link
Collaborator Author

zerebos commented Nov 4, 2023

You could modify your existing container to match this change and test for yourself if you're using Docker. Might be worth moving this part to a discussion though if you're interested.

@jacksgt
Copy link

jacksgt commented Dec 5, 2023

Thanks for this awesome work! I can confirm that it works with Trilium v.0.62.3 on Firefox for Android. 👏

@dahamsta
Copy link

dahamsta commented Dec 5, 2023

Same, lovely job, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA Support
4 participants