-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webmanifest for wider compatibility #4371
Conversation
Partially fixes zadam#920
By the way, let me know if you want me to work on offline usage for PWA, after toying around with it some is may be mostly possible. |
Sure, although I'm curious what that "mostly" means :-) |
Some caveats would be:
Number 1 can't really be worked around without explicitly attempting to cache every single note on first install, which is technically possible but can also lead to a lot of stale information. Number 2 can be worked around by pre-caching all the potential resources like that though it is a bit of a pain to do. Number 3 can't be worked around without actual changes to Trilium. So either way I think a network-first approach is the right one for Trilium, and combine this with some updates to the mobile interface (#3975, #4335) I think that would alleviate a lot of the calls for a "proper" mobile app. |
Agreed. |
Thanks for this. Would I be right in saying that this wasn't rolled into 0.61.12? |
This was merged into main which will become 0.62 |
Great, thanks, I'll test as soon as I get it. |
You could modify your existing container to match this change and test for yourself if you're using Docker. Might be worth moving this part to a discussion though if you're interested. |
Thanks for this awesome work! I can confirm that it works with Trilium v.0.62.3 on Firefox for Android. 👏 |
Same, lovely job, thanks. |
Partially fixes #920, just does not enable offline usage.