Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jump to ToC for nested headers #4281

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix jump to ToC for nested headers #4281

merged 1 commit into from
Sep 25, 2023

Conversation

zerebos
Copy link
Collaborator

@zerebos zerebos commented Sep 22, 2023

This is meant to fix #4228. I saw your comment there about trying to search in arbitrary depth of the ckeditor model #4228 (comment), but I thought why not try to make it use the same method as read-only notes?

I tested this out locally of course and it seems to work as expected for a bunch of different nested cases. But you can just consider this a proposal and feel free to close it if you don't think it's the best way forward.

@zadam zadam merged commit 613b83e into zadam:master Sep 25, 2023
2 checks passed
@zadam
Copy link
Owner

zadam commented Sep 25, 2023

I kind of expected some trouble because of all the advanced stuff CKEditor does on the background, but if this simple straightforward approach works, all the better ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Bug report) TOC problem
2 participants