Fix jump to ToC for nested headers #4281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to fix #4228. I saw your comment there about trying to search in arbitrary depth of the ckeditor model #4228 (comment), but I thought why not try to make it use the same method as read-only notes?
I tested this out locally of course and it seems to work as expected for a bunch of different nested cases. But you can just consider this a proposal and feel free to close it if you don't think it's the best way forward.