fix: update variable and function names #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and zui.plugin.zsh Breaking change: Enable ZUI demos only if ZUI[DEMOS] is set, i.e.: typeset -A ZUI; ZUI[DEMOS]=1 This change updates variable and function names in the files stdlib.lzui, utillib.lzui, and zui.plugin.zsh. The updates include changing the names from using underscores to using hyphens, following a more consistent naming convention throughout the codebase. By updating the names, the codebase becomes more readable and adheres to best practices. This change also improves maintainability, as the code is now more self-explanatory. There are no significant consequences or considerations resulting from this change. Resolves: #4 Signed-off-by: Salvydas Lukosius <[email protected]>
- Updated the `.editorconfig` file to include `*.lzui` file extension with a consistent indent style and size of 2. - Created new files `.github/.cspell/project-ignored.txt` and `.github/.cspell/project-words.txt` to ignore specific words in code spell checking. - Added a new GitHub Actions workflow for syncing labels. - Updated the GitHub Actions workflow for trunk checks, removing a weekend schedule. - Added a new `.trunk/.gitignore` file to customize what files are ignored by Trunk. - Renamed and relocated the `.markdownlint.yaml` configuration file. - Added a new `.trunk/configs/.yamllint.yaml` configuration file for Yamllint. - Updated Signed-off-by: Salvydas Lukosius <[email protected]>
ss-o
added
breaking-change 💥
The link in the README has been fixed to point to the correct location in the wiki. Signed-off-by: Salvydas Lukosius <[email protected]>
Signed-off-by: Sall <[email protected]>
This commit enhances the ZUI standard library initialization by refactoring the code in `stdlib.lzui`. The changes introduce consistency in the variable naming conventions, fix a typo, and optimize the code structure. The improvements ensure that ZUI applications have better readability and maintainability. No issues Signed-off-by: Salvydas Lukosius <[email protected]>
This commit adds a new GitHub Actions workflow named "Zsh" to perform continuous integration for Zsh files in the repository. The workflow is triggered on push events to the "main" branch and for tags following the "v*.*.*" pattern. It also runs on pull requests that modify Zsh files or files in the "functions" directory. The workflow consists of two jobs: 1. "zsh-matrix": This job sets up a matrix of Zsh files based on the files in the repository. It uses the `find` command combined with `jq` to identify and set the Zsh files for the matrix. 2. "zsh-n": This job runs the Zsh linter (`zsh -n`) and the Zsh compiler (`zcompile`) for each file in the matrix created by the previous job. This new workflow will help ensure the quality and correctness of Zsh files in the repository, providing early feedback on potential issues. It will promote better code reliability and maintainability in Zsh scripts. Signed-off-by: Salvydas Lukosius <[email protected]>
error handling This change updates the terminal reattachment logic and error handling in the `zui-usetty-wrapper` function. The code now checks for the availability of a terminal and handles cases where there is no terminal or `/dev/tty` is not present. It also correctly restores the file descriptor state after running the command. These improvements ensure robustness and prevent potential errors when reattaching to the terminal. Signed-off-by: Salvydas Lukosius <[email protected]>
ss-o
force-pushed
the
fix-zui-functions
branch
from
22e8b51
to
327a9c0
Compare
The commit adds new ignored words and files to improve spell checking accuracy. Signed-off-by: Salvydas Lukosius <[email protected]>
Signed-off-by: Salvydas Lukosius <[email protected]>
ss-o
force-pushed
the
fix-zui-functions
branch
from
e5f763c
to
5eaaf6a
Compare
This refactor improves the indentation structure and readability. It enhances maintainability and makes it easier to comprehend the rendering process. Signed-off-by: Salvydas Lukosius <[email protected]>
ss-o
force-pushed
the
fix-zui-functions
branch
from
5eaaf6a
to
0e23194
Compare
Signed-off-by: Salvydas Lukosius <[email protected]>
ss-o
force-pushed
the
fix-zui-functions
branch
from
0e5a510
to
fae4237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Updates codebase following current zsh plugin standard.
❗ Breaking change:
Enable ZUI demos only if
ZUI[DEMOS]is set before loading the plugin, i.e.:typeset -A ZUI; ZUI[DEMOS]=1🆙 This change updates variable and function names in the files
stdlib.lzui,utillib.lzui, andzui.plugin.zsh. The updates include changing the names from using underscores to using hyphens, following a more consistent naming convention throughout the codebase.☑️ By updating the names, the codebase becomes more readable and adheres to best practices. This change also improves maintainability, as the code is now more self-explanatory. There are no significant consequences or considerations resulting from this change.
Resolves: #4