Define http handlers as functions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a mild refactor with the sole goal of reutilizing the exisiting handlers alongside others and the stdlib ones. In this way the upcoming changes can be designed as small "middlewares" insted of a complex type with some business logic on them.
|
Great pull request! Your refactoring makes our code simple and short. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Hi, is me again
. I just finished with the revealgo + multiplex integration, and you can see how it looks on this branch. Unfortunately, when I was cleaning up what I did on said branch I found myself doing a mild refactor in the process, so instead of disturbing you with a big change I would rather split it in two separated pull requests (so expect another one coming from my side).
What changed?
I did a mild refactor with the sole goal of reutilizing the exisiting handlers alongside others and the stdlib ones. In this way the upcoming changes can be designed as small "middlewares" insted of complex types with some business logic on them.
By the way, I think this might solve #4 since now revealgo uses the
http.Dirstdlib function to serve the content. Either way, I am not 100% since I am not a Windows user 🤷♂️.