fix: error handling

yrming · Dec 31, 2023 · 6c1e90e · 6c1e90e
1 parent 53a64c5
commit 6c1e90e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "publisher": "YRM",
   "name": "starter-templates",
   "displayName": "Starter Templates",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "Kickstart your project with a Starter Template in VSCode",
   "license": "MIT",
   "repository": {

diff --git a/src/commands/starter.ts b/src/commands/starter.ts
@@ -31,7 +31,7 @@ export class StarterCommands extends BaseCommands {
     if (!triggerData)
       return
 
-    await window.withProgress({
+    const code = await window.withProgress({
       location: ProgressLocation.Notification,
     }, async (progress) => {
       progress.report({
@@ -72,14 +72,19 @@ export class StarterCommands extends BaseCommands {
           default:
             break
         }
+
+        if (templateId !== 'create-next-app')
+          await this.handleCommonActions(projectPath!)
+
+        return 0
       }
       catch (error) {
         window.showErrorMessage('Failed to create prpject!')
+        return -1
       }
-
-      if (templateId !== 'create-next-app')
-        await this.handleCommonActions(projectPath!)
     })
+
+    return code
   }
 
   private async handleCommonActions(projectPath: string) {
@@ -104,7 +109,7 @@ export class StarterCommands extends BaseCommands {
           })
         }
         catch (error) {
-          window.showErrorMessage('Failed to install dependencies!')
+          window.showWarningMessage('Failed to install dependencies!')
         }
       })
     }

diff --git a/src/create.ts b/src/create.ts
@@ -34,8 +34,9 @@ async function handleStarterCreateTrigger(wf: WorkspaceFolder): Promise<void> {
 
   try {
     markProjectCreationStarted()
-    await createStarterProject(fsPath(wf.uri), json)
-    handleStarterWelcome(wf, json)
+    const success = await createStarterProject(fsPath(wf.uri), json)
+    if (success)
+      handleStarterWelcome(wf, json)
   }
   finally {
     markProjectCreationEnded()