Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel feature #684

Closed

Conversation

amrutha-m206
Copy link
Contributor

@amrutha-m206 amrutha-m206 commented Oct 27, 2024

I have added a carousel effect feature assigned for the issue i raised .

Issue #681

The effect has 3 pictures which changes automatically one after the other after few seconds and also you can navigate using the naviagtion button on the bottom of the picture.
I have also added the updated Readme and the images for Readme in the image folder

carousel_demo.mp4

@aayush105
Copy link
Member

Rather than adding the images in the README.md file add the output video of carousel. @amrutha-m206

@amrutha-m206
Copy link
Contributor Author

Rather than adding the images in the README.md file add the output video of carousel. @amrutha-m206

done i have added

@aayush105
Copy link
Member

why did you made changes in main index.html file? Make your separate index.html file and css under your working folder.
Don't change the main index.html file. @amrutha-m206 Also add the output video in the description

@amrutha-m206
Copy link
Contributor Author

why did you made changes in main index.html file? Make your separate index.html file and css under your working folder. Don't change the main index.html file. @amrutha-m206 Also add the output video in the description

no i havent made any changes in the main index.html i created my own index.html and style.css and uploaded in my branch.
i guess it is conflicting with the main index.html as i uploaded files i will try uploading the folder instead .

@aayush105
Copy link
Member

why did you made changes in main index.html file? Make your separate index.html file and css under your working folder. Don't change the main index.html file. @amrutha-m206 Also add the output video in the description

no i havent made any changes in the main index.html i created my own index.html and style.css and uploaded in my branch. i guess it is conflicting with the main index.html as i uploaded files i will try uploading the folder instead .

image

see this you have made changes in the main index.html file you have not added your separate index.html file, make a separate folder of you project and add all the images , html and css files and make it organized.

@aayush105
Copy link
Member

I am closing this PR, make the new PR with your project folder in a organized way.

@aayush105 aayush105 closed this Oct 28, 2024
@amrutha-m206 amrutha-m206 deleted the carousel-feature branch October 28, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants