spanner: set google-cloud-resource-prefix metadata #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
google-cloud-resource-prefix
metadata to speed up spanner data RPCs.It seems that data RPCs still work without this, albeit with surprisingly reduced performance. I have not found anything in the spanner RPC API docs to indicate which RPCs should have this metadata set but the golang spanner client seems to be setting it for all session creation and data RPCs.
Not sure what is the preferred way to implement this. This PR adds a
metadata
field oncrate::apiv1::spanner_client::Client
to avoid having to pass it in to the public methods on the impl.Other approaches could be to instead explicitly pass in the metadata from call sites, and/or infer it from already available information like
database
fields on the request types when available.#323 (comment)
See: