-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows #41
Open
Skenvy
wants to merge
31
commits into
yoavbls:new-ci-cd
Choose a base branch
from
Skenvy:workflows
base: new-ci-cd
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Workflows #41
+2,356
−1,734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add dependabot file * Extensive gitignore * Into the wild blue yonder * Add the missing runs-on in cql * Update the nodev from a lockv 1 to a lockv 2 version * Run tests in xvfb * sudo apt * use the recommeneded "xvfb-maybe" * Clean make * Scope it to shake a stick at the release. * Reduce the pan of the full test * reset lock * Flag legacy peer deps * Correct the called path --------- Co-authored-by: Skenvy <>
yoavbls
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you some much for this contribution!
These workflows will let us move faster and test things better.
I wrote only a few comments and set the NPM_TOKEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI/CD
Test workflow
Release workflow
npm pack
vsce package
NPM_TOKEN
.Dependabot
package[-lock].json
xvfb-maybe
virtual display to run electron tests in headless workflow.npm ci
-able) with the package json.