Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inert to the boolean attributes list #3678

Merged

Conversation

kawadakk
Copy link
Contributor

@kawadakk kawadakk commented Jul 9, 2024

Description

Adds the inert global boolean attribute, which was added to the HTML Standard in 2022.

Checklist

  • I have reviewed my own code
  • I have added tests

Copy link

github-actions bot commented Jul 9, 2024

Visit the preview URL for this PR (updated for commit 8162cd0):

https://yew-rs-api--pr3678-patch-feat-macro-boo-id7zajva.web.app

(expires Tue, 16 Jul 2024 08:56:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@kawadakk
Copy link
Contributor Author

kawadakk commented Jul 9, 2024

error: associated function `lint` is never used
  --> packages/yew-macro/src/html_tree/lint/mod.rs:15:8
   |
14 | pub trait Lint {
   |           ---- associated function in this trait
15 |     fn lint(element: &HtmlElement);
   |        ^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

The CI failure is unrelated to the change made by the PR. It's probably caused by more precise dead_code linting in recent toolchains.

Copy link

github-actions bot commented Jul 9, 2024

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.794 314.772 309.861 1.850
Hello World 10 492.825 505.018 496.530 4.024
Function Router 10 1619.602 1657.137 1634.002 12.993
Concurrent Task 10 1005.791 1006.956 1006.466 0.378
Many Providers 10 1136.918 1159.540 1144.008 7.180

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 308.900 310.745 309.410 0.647
Hello World 10 495.874 554.498 504.613 17.641
Function Router 10 1632.120 1671.637 1650.196 12.721
Concurrent Task 10 1005.902 1007.077 1006.585 0.373
Many Providers 10 1202.454 1296.652 1256.553 23.308

Copy link

github-actions bot commented Jul 9, 2024

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 97.739 97.643 -0.097 -0.099%
boids 168.001 167.796 -0.205 -0.122%
communication_child_to_parent 90.241 90.183 -0.059 -0.065%
communication_grandchild_with_grandparent 102.480 102.416 -0.064 -0.063%
communication_grandparent_to_grandchild 97.920 97.852 -0.068 -0.070%
communication_parent_to_child 86.597 86.538 -0.059 -0.068%
contexts 102.089 102.006 -0.083 -0.081%
counter 83.261 83.183 -0.078 -0.094%
counter_functional 83.658 83.607 -0.051 -0.061%
dyn_create_destroy_apps 86.601 86.537 -0.063 -0.073%
file_upload 97.650 97.578 -0.072 -0.074%
function_memory_game 164.058 163.901 -0.156 -0.095%
function_router 337.604 337.271 -0.332 -0.098%
function_todomvc 158.131 157.901 -0.229 -0.145%
futures 225.941 225.778 -0.163 -0.072%
game_of_life 105.322 105.264 -0.059 -0.056%
immutable 185.600 185.600 0 0.000%
inner_html 77.588 77.536 -0.052 -0.067%
js_callback 105.845 105.766 -0.079 -0.075%
keyed_list 195.535 195.321 -0.214 -0.109%
mount_point 80.564 80.511 -0.054 -0.067%
nested_list 111.351 111.245 -0.105 -0.095%
node_refs 87.955 87.853 -0.103 -0.117%
password_strength 1713.025 1711.744 -1.281 -0.075%
portals 90.822 90.756 -0.066 -0.073%
router 308.322 307.977 -0.346 -0.112%
simple_ssr 137.812 137.708 -0.104 -0.076%
ssr_router 374.946 374.545 -0.401 -0.107%
suspense 112.130 112.039 -0.091 -0.081%
timer 86.168 86.099 -0.069 -0.080%
timer_functional 94.914 94.852 -0.062 -0.066%
todomvc 139.247 139.051 -0.196 -0.141%
two_apps 83.256 83.206 -0.050 -0.060%
web_worker_fib 131.561 131.457 -0.104 -0.079%
web_worker_prime 182.040 181.890 -0.150 -0.083%
webgl 80.263 80.212 -0.051 -0.063%

✅ None of the examples has changed their size significantly.

Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

@WorldSEnder WorldSEnder enabled auto-merge (squash) July 9, 2024 16:03
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WorldSEnder WorldSEnder merged commit 62567cc into yewstack:master Jul 25, 2024
16 of 20 checks passed
@kawadakk kawadakk deleted the patch/feat-macro-bool-attr-inert branch July 26, 2024 01:27
@WorldSEnder WorldSEnder added the A-yew Area: The main yew crate label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants