Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rubocop to v1.68.0 #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 15, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) '1.66.1' -> '1.68.0' age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.68.0

Compare Source

New features
Bug fixes
  • #​13401: Fix a false negative for Style/RedundantLineContinuation when there is a line continuation at the EOF. ([@​koic][])
  • #​13368: Fix an incorrect autocorrect for Naming/BlockForwarding with Style/ExplicitBlockArgument. ([@​koic][])
  • #​13391: Fix deserialization of unknown encoding offenses. ([@​earlopain][])
  • #​13348: Ensure Style/BlockDelimiters autocorrection does not move other code between the block and comment. ([@​dvandersluis][])
  • #​13382: Fix an error during error handling for custom ruby extractors when the extractor is a class. ([@​earlopain][])
  • #​13309: Fix a false negative for Lint/UselessAssignment cop when there is a useless assignment followed by a block. ([@​pCosta99][])
  • #​13255: Fix false negatives for Style/MapIntoArray when using non-splatted arguments. ([@​vlad-pisanov][])
  • #​13356: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before []=. ([@​earlopain][])
  • #​13365: Fix false positives for Lint/SafeNavigationConsistency when using safe navigation on the LHS with operator method on the RHS of &&. ([@​koic][])
  • #​13390: Fix false positives for Style/GuardClause when using a local variable assigned in a conditional expression in a branch. ([@​koic][])
  • #​13337: Fix false positives for Style/RedundantLineContinuation when required line continuations for && is used with an assignment after a line break. ([@​koic][])
  • #​13387: Fix false positives in Style/RedundantParentheses when parentheses are used around method chain with do...end block in keyword argument. ([@​koic][])
  • #​13341: Fix false positives for Lint/SafeNavigationChain when a safe navigation operator is used with a method call as the RHS operand of && for the same receiver. ([@​koic][])
  • #​13324: Fix --disable-uncorrectable to not insert a comment inside a string continuation. ([@​dvandersluis][])
  • #​13364: Fix incorrect autocorrect with Lint/UselessAssignment a multiple assignment or for contains an inner assignment. ([@​dvandersluis][])
  • #​13353: Fix an incorrect autocorrect for Style/BlockDelimiters when EnforcedStyle: semantic is set and used with Layout/SpaceInsideBlockBraces. ([@​koic][])
  • #​13361: Fix false positives for Style/RedundantInterpolationUnfreeze and Style/RedundantFreeze when strings contain interpolated global, instance, and class variables. ([@​vlad-pisanov][])
  • #​13343: Prevent Layout/LineLength from breaking up a method with arguments chained onto a heredoc delimiter. ([@​dvandersluis][])
  • #​13374: Return exit code 0 with --display-only-correctable and --display-only-safe-correctable when no offenses are displayed. ([@​dvandersluis][])
  • #​13193: Fix false positive in Style/MultipleComparison when ComparisonsThreshold exceeds 2. ([@​fatkodima][],[@​vlad-pisanov][])
  • #​13325: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using a postfix unless for file existence checks before creating a file, in cases with Dir.mkdir. ([@​kotaro0522][])
  • #​13397: Update PercentLiteralCorrector to be able to write pairs of delimiters without excessive escaping. ([@​dvandersluis][])
  • #​13336: Update Style/SafeNavigation to not autocorrect if the RHS of an and node is an or node. ([@​dvandersluis][])
  • #​13378: When removing parens in Style/TernaryParentheses with a send node condition, ensure its arguments are parenthesized. ([@​dvandersluis][])
Changes
  • #​13347: When running rubocop -V, show the analysis Ruby version of the current directory. ([@​earlopain][])

v1.67.0

Compare Source

New features
  • #​13259: Add new Lint/DuplicateSetElement cop. ([@​koic][])
  • #​13223: Add AllowRBSInlineAnnotation config option to Layout/LeadingCommentSpace to support RBS::Inline style annotation comments. ([@​tk0miya][])
  • #​13310: Display analysis Ruby version in rubocop -V. ([@​koic][])
Bug fixes
  • #​13314: Fix a false negative for Style/Semicolon when using a semicolon between a closing parenthesis after a line break and a consequent expression. ([@​koic][])
  • #​13217: Fix a false positive in Lint/ParenthesesAsGroupedExpression with compound ranges. ([@​gsamokovarov][])
  • #​13268: Fix a false positive for Style/BlockDelimiters when a single line do-end block with an inline rescue with a semicolon before rescue. ([@​koic][])
  • #​13298: Fix an error for Layout/AccessModifierIndentation when the access modifier is on the same line as the class definition. ([@​koic][])
  • #​13198: Fix an error for Style/OneLineConditional when using nested if/then/else/end. ([@​koic][])
  • #​13316: Fix an incorrect autocorrect for Lint/ImplicitStringConcatenation with Lint/TripleQuotes when string literals with triple quotes are used. ([@​koic][])
  • #​13220: Fix an incorrect autocorrect for Style/ArgumentsForwarding when using only forwarded arguments in brackets. ([@​koic][])
  • #​13202: Fix an incorrect autocorrect for Style/CombinableLoops when looping over the same data with different block variable names. ([@​koic][])
  • #​13291: Fix an incorrect autocorrect for Style/RescueModifier when using modifier rescue for method call with heredoc argument. ([@​koic][])
  • #​13226: Fix --auto-gen-config when passing an absolute config path. ([@​earlopain][])
  • #​13225: Avoid syntax error when correcting Style/OperatorMethodCall with / operations followed by a parenthesized argument. ([@​dvandersluis][])
  • #​13235: Fix an error for Style/IfUnlessModifier when multiline if that fits on one line and using implicit method call with hash value omission syntax. ([@​koic][])
  • #​13219: Fix a false positive for Style/ArgumentsForwarding with Ruby 3.0 and optional position arguments. ([@​earlopain][])
  • #​13271: Fix a false positive for Lint/AmbiguousRange when using rational literals. ([@​koic][])
  • #​13260: Fix a false positive for Lint/RedundantSafeNavigation with namespaced constants. ([@​earlopain][])
  • #​13224: Fix false positives for Style/OperatorMethodCall with named forwarding. ([@​earlopain][])
  • #​13213: Fix false positives for Style/AccessModifierDeclarations when AllowModifiersOnAttrs: true and using splat with a percent symbol array, or with a constant. ([@​koic][])
  • #​13145: Fix false positives for Style/RedundantLineContinuation when line continuations with comparison operator and the LHS is wrapped in parentheses. ([@​koic][])
  • #​12875: Fix false positive for Style/ArgumentsForwarding when argument is used inside a block. ([@​dvandersluis][])
  • #​13239: Fix false positive for Style/CollectionCompact when using delete_if. ([@​masato-bkn][])
  • #​13210: Fix omit_parentheses style for pattern match with value omission in single-line branch. ([@​gsamokovarov][])
  • #​13149: Handle crashes in custom Ruby extractors more gracefully. ([@​earlopain][])
  • #​13319: Handle literal forward slashes inside a regexp in Lint/LiteralInInterpolation. ([@​dvandersluis][])
  • #​13208: Fix an incorrect autocorrect for Style/IfWithSemicolon when single-line if/;/end when the then body contains a method call with [] or []=. ([@​koic][])
  • #​13318: Prevent modifying blocks with Style/HashEachMethods if the hash is modified within the block. ([@​dvandersluis][])
  • #​13293: Fix TargetRubyVersion from a gemspec when the gemspec is not named like the folder it is located in. ([@​earlopain][])
  • #​13211: Fix wrong autocorrect for Style/GuardClause when using heredoc without else branch. ([@​earlopain][])
  • #​13215: Fix wrong autocorrect for Lint/BigDecimalNew when using ::BigDecimal.new. ([@​earlopain][])
  • #​13215: Fix wrong autocorrect for Style/MethodCallWithArgsParentheses with EnforcedStyle: omit_parentheses and whitespace. ([@​earlopain][])
  • #​13302: Fix incompatible autocorrect between Style/RedundantBegin and Style/BlockDelimiters with EnforcedStyle: braces_for_chaining. ([@​earlopain][])
Changes
  • #​13221: Do not group accessors having RBS::Inline annotation comments in Style/AccessorGrouping. ([@​tk0miya][])
  • #​13286: Add AllowedMethods configuration to Layout/FirstMethodArgumentLineBreak. ([@​dvandersluis][])
  • #​13110: Add support in Style/ArgumentsForwarding for detecting forwarding of all anonymous arguments. ([@​dvandersluis][])
  • #​13222: Allow to write RBS::Inline annotation comments after method definition in Style/CommentedKeyword. ([@​tk0miya][])
  • #​13253: Emit a deprecation when custom cops inherit from RuboCop::Cop::Cop. ([@​earlopain][])
  • #​13300: Set EnforcedShorthandSyntax: either by default for Style/HashSyntax. ([@​koic][])
  • #​13254: Enhance the autocorrect for Naming/InclusiveLanguage when a sole suggestion is set. ([@​koic][])
  • #​13232: Make server mode aware of auto-restart for local config update. ([@​koic][])
  • #​13270: Make Style/SelectByRegexp aware of filter in Ruby version 2.6 or above. ([@​masato-bkn][])
  • #​9816: Refine Lint/SafeNavigationConsistency cop to check that the safe navigation operator is applied consistently and without excess or deficiency. ([@​koic][])
  • #​13256: Report and correct more Style/SafeNavigation offenses. ([@​dvandersluis][])
  • #​13245: Support filter/filter! in Style/CollectionCompact. ([@​masato-bkn][])
  • #​13281: Support Ruby 3.4 for Lint/UriRegexp to avoid obsolete API. ([@​koic][])
  • #​13229: Update Style/MapIntoArray to be able to handle arrays created using [].tap. ([@​dvandersluis][])
  • #​13305: Update Style/ReturnNilInPredicateMethodDefinition to detect implicit nil returns inside if. ([@​dvandersluis][])
  • #​13327: Make server mode aware of auto-restart for .rubocop_todo.yml update. ([@​koic][])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@yegor256
Copy link
Owner

@rultor please, try to merge, since 9 checks have passed

@rultor
Copy link
Collaborator

rultor commented Oct 15, 2024

@rultor please, try to merge, since 9 checks have passed

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
Copy link
Collaborator

rultor commented Oct 15, 2024

@rultor please, try to merge, since 9 checks have passed

@renovate[bot] @yegor256 Oops, I failed. You can see the full log here (spent 6min).

            at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
            at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
            at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
            at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
            at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
            at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
            at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
            at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
            at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
            at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
            at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
            at java.lang.reflect.Method.invoke (Method.java:566)
            at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
            at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
            at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
            at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
        [ERROR] 
        [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [ERROR] 
        [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException
        
            /usr/local/rvm/gems/ruby-3.2.2/gems/qbash-0.0.4/lib/qbash.rb:73:in `block in qbash'
            /usr/local/rvm/rubies/ruby-3.2.2/lib/ruby/3.2.0/open3.rb:228:in `popen_run'
            /usr/local/rvm/rubies/ruby-3.2.2/lib/ruby/3.2.0/open3.rb:210:in `popen2e'
            /usr/local/rvm/gems/ruby-3.2.2/gems/qbash-0.0.4/lib/qbash.rb:56:in `qbash'
            lib/pgtk/liquibase_task.rb:83:in `block in run'
            lib/pgtk/liquibase_task.rb:82:in `chdir'
            lib/pgtk/liquibase_task.rb:82:in `run'
            lib/pgtk/liquibase_task.rb:48:in `block (2 levels) in initialize'
            /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/file_utils_ext.rb:58:in `verbose'
            lib/pgtk/liquibase_task.rb:46:in `block in initialize'
            /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/task.rb:281:in `block in execute'
            /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/task.rb:281:in `each'
            /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/task.rb:281:in `execute'
            /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/task.rb:219:in `block in invoke_with_call_chain'
            /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/task.rb:199:in `synchronize'
            /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/task.rb:199:in `invoke_with_call_chain'
            /usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/lib/rake/task.rb:188:in `invoke'
            test/test_pool.rb:173:in `block in bootstrap'
            /usr/local/rvm/rubies/ruby-3.2.2/lib/ruby/3.2.0/tmpdir.rb:94:in `mktmpdir'
            test/test_pool.rb:157:in `bootstrap'
            test/test_pool.rb:39:in `test_reads_version'


TestPgsqlTask
  test_basic                                                     \u001b[32m PASS\u001b[0m (8.44s)

Finished in 174.54735s
12 tests, 4 assertions, \u001b[31m0 failures, 8 errors, \u001b[0m\u001b[33m0 skips\u001b[0m
Coverage report generated for Unit Tests to /home/r/repo/coverage/coverage.xml. 170 / 193 LOC (88.08%) covered
rake aborted!
Command failed with status (1)
/usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `eval'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
container 95ffe8881910a2c43124b41713a5d505ab7a830511033bc7b86cb64f2831f15f is dead
Tue Oct 15 16:40:19 UTC 2024

@renovate renovate bot changed the title Update dependency rubocop to v1.67.0 Update dependency rubocop to v1.68.0 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants