-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PATEGAN integration [SD-50] #129
Open
jfsantos-ds
wants to merge
3
commits into
dev
Choose a base branch
from
feat/pategan
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsantos-ds
force-pushed
the
feat/pategan
branch
from
December 14, 2021 19:05
b9dffa6
to
1a57bb9
Compare
jfsantos-ds
requested review from
arunnthevapalan,
gabrielfritzcavalcante,
mglcampos,
ubabe53 and
UrbanoFonseca
December 14, 2021 19:14
Currently the base structure is refactored from a previous implementation.
|
jfsantos-ds
force-pushed
the
feat/pategan
branch
2 times, most recently
from
December 15, 2021 18:11
b55b820
to
95bbab0
Compare
jfsantos-ds
changed the title
feat: PATEGAN main implementation
feat: PATEGAN integration
Dec 21, 2021
jfsantos-ds
changed the title
feat: PATEGAN integration
feat: PATEGAN integration [SD-50]
Dec 23, 2021
fabclmnt
reviewed
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PATEGAN code seems good to go, but please provide an example.
@jfsantos-ds
Remove duplicate test files after renaming Use BaseModel variables
jfsantos-ds
force-pushed
the
feat/pategan
branch
from
April 20, 2022 15:22
fe6d374
to
ca53aaa
Compare
jfsantos-ds
requested review from
alexbarros,
aquemy,
fabclmnt and
jtook
and removed request for
mglcampos,
UrbanoFonseca and
gabrielfritzcavalcante
April 21, 2022 16:36
@fabclmnt I believe this should be ready to merge, wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the PATEGAN model in accordance with the original article.