Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/RFC] Follow chains of fixits #4263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Sep 12, 2024

Sometimes resolving a fixit (eventually) results in more than one fixit. In those cases, ycmd will send the first one and set keep_going to True.
We can't reuse request data, because we need to inform ycmd about the updated state of the buffers.

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

This is the client counterpart to ycm-core/ycmd#1760


This change is Reviewable

Sometimes resolving a fixit (eventually) results in more than one fixit.
In those cases, ycmd will send the first one and set `keep_going` to
`True`.
We can't reuse request data, because we need to inform ycmd about the
updated state of the buffers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant