This repository has been archived by the owner on Jan 27, 2019. It is now read-only.
renaming in random order #372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helps to improve sequential renaming. so far names are the same every* time for each member, which leaks information. *as long as type count / order is the same. but its still pretty bad without random. should this be improved by using the random seed? not unless you want to change the random seed on every obfuscation which kinda defeats the purpose.
|
Thanks for your contribution! However, I would prefer using the built-in RandomNumberGenerator service as it ensure each obfuscation would produce the same result if the same random seed is provided. |
|
Personally I'll prefer using RandomGenerator.Shuffle method to randomize the order, as sorting a list takes a longer time than a simple shuffling. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helps to improve sequential renaming.
so far names are the same every* time for each member, which leaks information.
*as long as type count / order is the same. but its still pretty bad without random.
should this be improved by using the random seed?
not unless you want to change the random seed on every obfuscation which kinda defeats the purpose.