Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add .gitattributes to skeleton #1

Merged
merged 1 commit into from
Feb 15, 2024
Merged

feat: add .gitattributes to skeleton #1

merged 1 commit into from
Feb 15, 2024

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Feb 15, 2024

In order to reduce the bundle size in vendors, the .gitattributes file can be added to exclude unneeded files

yceruto
yceruto approved these changes Feb 15, 2024
View reviewed changes
Copy link
Owner

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! thanks a lot 🤟

@yceruto
Copy link
Owner

yceruto commented Feb 15, 2024 •
edited
Loading

Can you please add tests/Expected/acme-bundle/.gitattributes.expected file with the same content of the template, so tests will pass?

@yceruto yceruto merged commit 619b0cc into yceruto:main Feb 15, 2024
4 checks passed
@mtarld mtarld deleted the feat/gitattributes branch February 15, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtarld @yceruto