Added compatibility for Linux platform #5
Conversation
There was a problem hiding this comment.
I'd really would like to avoid adding a third-party lib just for managing console output, but I'm open to get educated as I didn't find the time to look into the matter on linux yet (I only know about the ANSI control codes which should work on both linux and mac)
Warning: I only skimmed over it quickly, so I might have missed quite a few spots, hopefully once you address my comments there'll be a more thorough review.
|
@Scienziatogm needs a rebase, and there's still 2 unresolved conversations |
| @@ -284,7 +284,7 @@ void DumpConsoleHelp(); | |||
|
|
|||
| COORD FServerConsole::GetCursorPosition() | |||
| { | |||
| COORD hCursorPosition = 0; | |||
| COORD hCursorPosition = { 0, 0 }; | |||
There was a problem hiding this comment.
| COORD hCursorPosition = { 0, 0 }; | |
| COORD hCursorPosition = {}; |
| } | ||
| if ( hInputEvents == '\n' ) | ||
| { | ||
| auto& sInput = m_sInput; |
There was a problem hiding this comment.
| auto& sInput = m_sInput; | |
| auto sInput = m_sInput; |
Not sure if we need a reference here
| COORD retval; | ||
| getyx( stdscr, retval.Y, retval.X ); | ||
| return retval; |
There was a problem hiding this comment.
| COORD retval; | |
| getyx( stdscr, retval.Y, retval.X ); | |
| return retval; | |
| COORD hPos; | |
| getyx( stdscr, hPos.Y, hPos.X ); | |
| return hPos; |
| int retval = move( hCursorPosition.Y, hCursorPosition.X ); | ||
| refresh(); | ||
| return retval == OK ? true : false; |
There was a problem hiding this comment.
| int retval = move( hCursorPosition.Y, hCursorPosition.X ); | |
| refresh(); | |
| return retval == OK ? true : false; | |
| int iStatus = move( hCursorPosition.Y, hCursorPosition.X ); | |
| refresh(); | |
| return iStatus == OK; |
| COORD() | ||
| { | ||
| this->Y = 0; | ||
| this->X = 0; | ||
| } |
| COORD( int Y, int X ) | ||
| { | ||
| this->Y = Y; | ||
| this->X = X; | ||
| } |
There was a problem hiding this comment.
| COORD( int Y, int X ) | |
| { | |
| this->Y = Y; | |
| this->X = X; | |
| } | |
| COORD( int iX, int iY ) | |
| { | |
| X = iX; | |
| Y = iY; | |
| } |
Make sure you validate the order of the parameters on the rest of the code (with or without accepting this suggestion)
Added compatibility for Linux Platform. Tested on x86_64 ubuntu dedicated server.