-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xr_cnvcld flag to namelist and configure files #1
Add xr_cnvcld flag to namelist and configure files #1
Conversation
@@ -80,6 +80,7 @@ case "${fv3_res}" in | |||
export nthreads_fv3_gfs=1 | |||
export nthreads_ufs=1 | |||
export nthreads_ufs_gfs=1 | |||
export xr_cnvcld=.false. # Do not pass conv. clouds to Xu-Randall cloud fraction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation needs adjustment
@@ -103,7 +104,8 @@ case "${fv3_res}" in | |||
export nthreads_fv3_gfs=1 | |||
export nthreads_ufs=1 | |||
export nthreads_ufs_gfs=1 | |||
export cdmbgwd="0.14,1.8,1.0,1.0" # mountain blocking, ogwd, cgwd, cgwd src scaling | |||
export xr_cnvcld=.false. # Do not pass conv. clouds to Xu-Randall cloud fraction | |||
export cdmbgwd="0.14,1.8,1.0,1.0" # mountain blocking, ogwd, cgwd, cgwd src scaling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation !
@@ -96,7 +96,8 @@ case "${fv3_res}" in | |||
export nthreads_fv3_gfs=1 | |||
export nthreads_ufs=1 | |||
export nthreads_ufs_gfs=1 | |||
export cdmbgwd="0.071,2.1,1.0,1.0" # mountain blocking, ogwd, cgwd, cgwd src scaling | |||
export xr_cnvcld=.false. # Do not pass conv. clouds to Xu-Randall cloud fraction | |||
export cdmbgwd="0.071,2.1,1.0,1.0" # mountain blocking, ogwd, cgwd, cgwd src scaling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
@@ -137,6 +138,7 @@ case "${fv3_res}" in | |||
export nthreads_fv3_gfs=1 | |||
export nthreads_ufs=1 | |||
export nthreads_ufs_gfs=1 | |||
export xr_cnvcld=.false. # Do not pass conv. clouds to Xu-Randall cloud fraction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lisa, the changes are good except a few indentations need to be adjusted
I see, yes that looks odd. I will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
This PR adds the namelist option xr_cnvcld into Fanglin's PR dycore_update_hr4. In order to use this namelist flag the version of the ufs-weather-model needs to include this update: ufs-community/ufs-weather-model#2202