Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mypy #30

Merged
merged 1 commit into from
Jul 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,8 @@ jobs:
run: make flake8
- name: "lint: pylint"
run: make pylint
# Temporarily disabled due to bugs in typing in click library
# https://github.com/pallets/click/pull/2559
# https://github.com/python/mypy/issues/13250
# https://github.com/python/mypy/issues/13449
#- {name: "lint: mypy", run: make mypy }
- name: "lint: mypy"
run: make mypy

push_to_dockerhub:
runs-on: ubuntu-latest
Expand Down
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ clean:


.PHONY: lint
lint: isort black flake8 pylint
lint: isort black flake8 pylint mypy

.PHONY: isort
isort:
Expand All @@ -151,6 +151,10 @@ pylint:
pylint src
pylint --disable=missing-docstring tests

.PHONY: mypy
mypy:
mypy src tests

.PHONY: format
format:
isort .
Expand All @@ -160,11 +164,12 @@ format:
.PHONY: help
help:
@echo "Base targets:"
@echo " lint Run linters. Alias for \"isort black flake8 pylint\"."
@echo " lint Run linters. Alias for \"isort black flake8 pylint mypy\"."
@echo " isort Perform isort checks."
@echo " black Perform black checks."
@echo " flake8 Perform flake8 checks."
@echo " pylint Perform pylint checks."
@echo " mypy Perform mypy checks."
@echo " format Re-format source code to conform style settings enforced by"
@echo " isort and black tools."
@echo " prepare-changelog Add an autobuild version entity to changelog"
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ test = [
"types-tabulate",
"types-pyOpenSSL",
"types-setuptools",
#bandit = "*"
"behave",
"docker",
"docker-compose",
Expand Down