-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store state data in zookeeper #219
Store state data in zookeeper #219
Conversation
a21b2cf
to
a18c539
Compare
a18c539
to
0d213ff
Compare
Is the PR in draft on purpose? Or you just forgot to click "Ready for review"? |
Yes, I forgot to click "Ready for review" By the way, what do you think about making the store-state-zk flag and creating a default path for storing statistics? I don’t like that in this case there will be one path for storing statistics for hosts from different shards, but perhaps this problem should be left on the user’s side. But in some scenarios it may be useful. It would be cool in ch-tools to know which shard the host belongs to. Do we have such an opportunity? Using this the code can be made much better |
4678dfd
to
dafdf7e
Compare
I have no strong preference between the current implementation and described rework. Choose the one you prefer.
Shard name can be obtained from ClickHouse config, "shard" macro. Another option is to add a setting with shard name to ch-tools config. |
I'm inclined to leave the current implementation for flexibility in storing statistics in zk. |
No description provided.