Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store state data in zookeeper #219

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

NikitaUnisikhin
Copy link
Contributor

No description provided.

@NikitaUnisikhin NikitaUnisikhin marked this pull request as draft August 8, 2024 12:27
@NikitaUnisikhin NikitaUnisikhin force-pushed the store_state_monitoring branch 2 times, most recently from a21b2cf to a18c539 Compare August 9, 2024 12:28
@Alex-Burmak
Copy link
Member

Is the PR in draft on purpose? Or you just forgot to click "Ready for review"?

@NikitaUnisikhin
Copy link
Contributor Author

NikitaUnisikhin commented Aug 9, 2024

Yes, I forgot to click "Ready for review"

By the way, what do you think about making the store-state-zk flag and creating a default path for storing statistics? I don’t like that in this case there will be one path for storing statistics for hosts from different shards, but perhaps this problem should be left on the user’s side. But in some scenarios it may be useful.

It would be cool in ch-tools to know which shard the host belongs to. Do we have such an opportunity? Using this the code can be made much better

@NikitaUnisikhin NikitaUnisikhin marked this pull request as ready for review August 9, 2024 19:26
@Alex-Burmak
Copy link
Member

By the way, what do you think about making the store-state-zk flag and creating a default path for storing statistics? I don’t like that in this case there will be one path for storing statistics for hosts from different shards, but perhaps this problem should be left on the user’s side. But in some scenarios it may be useful.

I have no strong preference between the current implementation and described rework. Choose the one you prefer.

It would be cool in ch-tools to know which shard the host belongs to. Do we have such an opportunity? Using this the code can be made much better

Shard name can be obtained from ClickHouse config, "shard" macro. Another option is to add a setting with shard name to ch-tools config.

@NikitaUnisikhin
Copy link
Contributor Author

I'm inclined to leave the current implementation for flexibility in storing statistics in zk.
@Alex-Burmak I don't have rights to merge. Merge please if there are no more comments on this PR.

@Alex-Burmak Alex-Burmak merged commit 2455a54 into yandex:main Aug 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants