Skip to content

Commit

Permalink
Enable mypy (#30)
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex-Burmak authored Jul 26, 2023
1 parent 854f386 commit 782f405
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,8 @@ jobs:
run: make flake8
- name: "lint: pylint"
run: make pylint
# Temporarily disabled due to bugs in typing in click library
# https://github.com/pallets/click/pull/2559
# https://github.com/python/mypy/issues/13250
# https://github.com/python/mypy/issues/13449
#- {name: "lint: mypy", run: make mypy }
- name: "lint: mypy"
run: make mypy

push_to_dockerhub:
runs-on: ubuntu-latest
Expand Down
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ clean:


.PHONY: lint
lint: isort black flake8 pylint
lint: isort black flake8 pylint mypy

.PHONY: isort
isort:
Expand All @@ -151,6 +151,10 @@ pylint:
pylint src
pylint --disable=missing-docstring tests

.PHONY: mypy
mypy:
mypy src tests

.PHONY: format
format:
isort .
Expand All @@ -160,11 +164,12 @@ format:
.PHONY: help
help:
@echo "Base targets:"
@echo " lint Run linters. Alias for \"isort black flake8 pylint\"."
@echo " lint Run linters. Alias for \"isort black flake8 pylint mypy\"."
@echo " isort Perform isort checks."
@echo " black Perform black checks."
@echo " flake8 Perform flake8 checks."
@echo " pylint Perform pylint checks."
@echo " mypy Perform mypy checks."
@echo " format Re-format source code to conform style settings enforced by"
@echo " isort and black tools."
@echo " prepare-changelog Add an autobuild version entity to changelog"
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ test = [
"types-tabulate",
"types-pyOpenSSL",
"types-setuptools",
#bandit = "*"
"behave",
"docker",
"docker-compose",
Expand Down

0 comments on commit 782f405

Please sign in to comment.