Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-api-stub #6004

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add node-api-stub #6004

wants to merge 1 commit into from

Conversation

Freed-Wu
Copy link

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@Freed-Wu Freed-Wu force-pushed the node-api-stub branch 2 times, most recently from 9cb6dc6 to c375ae3 Compare December 18, 2024 15:42
@Freed-Wu Freed-Wu changed the title Add napi-bindings Add node-api-stub Dec 18, 2024
@Freed-Wu Freed-Wu force-pushed the node-api-stub branch 2 times, most recently from b410ec9 to a56534f Compare December 19, 2024 04:16
@Freed-Wu Freed-Wu force-pushed the node-api-stub branch 2 times, most recently from 92b24c6 to d9ffbe3 Compare December 19, 2024 05:35
@Freed-Wu
Copy link
Author

A test has been added.

@waruqi
Copy link
Member

waruqi commented Dec 22, 2024

please fix ci test errors

@Freed-Wu
Copy link
Author

why add_links("node_api") don't make the result gcc -lnode_api?

@waruqi
Copy link
Member

waruqi commented Dec 22, 2024

why add_links("node_api") don't make the result gcc -lnode_api?

because it is a compilation error. No test link yet

checking for c links(node_api)
checking for c snippet(test)
checkinfo: ...amdir/core/sandbox/modules/import/core/tool/compiler.lua:84: @programdir/modules/core/tools/gcc.lua:966: /var/folders/9f/9p4dh6hs5yddrk7drxq8rc_80000gn/T/.xmake501/241219/_A03737E1A4914FBF9454B8AA702B5626.c:6:17: error: call to undeclared function 'napi_get_undefined'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
napi_get_undefined(p, q);
^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants