add node-addon-api package for linux #4505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Jun 28, 2024
waruqi
reviewed
Jun 28, 2024
packages/n/node-addon-api/xmake.lua
Outdated
| "https://github.com/nodejs/node-addon-api.git") | ||
| add_versions("v8.0.0", "42424c5206b9d67b41af4fcff5d6e3cb22074168035a03b8467852938a281d47") | ||
|
|
||
| add_deps("node", {kind = 'binary', system = true}) |
There was a problem hiding this comment.
no this package in xmake-repo now.
There was a problem hiding this comment.
I couldn't find it, removing system = true gives me this error:
error: package(node) not found!
There was a problem hiding this comment.
so you should add node as package first. and add on_fetch to find system node in node package at least. like opengl package.
waruqi
reviewed
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this package for node-addon-api as the project relies on their own build system (node-gyp) that I didn't want to use.
It only supports Linux for now as the
.gypfiles on their repository seem to indicate that platform specific steps are needed for Windows and Macos.