Various fixes and improvements to latching behavior #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if `Caps_Lock` is on the second level of some key, and `Shift` is latched, pressing the key will lock `Caps` while also breaking the `Shift` latch, ensuring that the next character is properly uppercase. (Prior to this commit, both `Shift` and `Caps` would be active, so the next character would be lowercase.) Signed-off-by: Jules Bertholet <[email protected]>
Jules-Bertholet
changed the title
Jules-Bertholet
force-pushed
the
locks-break-latches
branch
from
d48426c to
7c82bb5
Compare
Jules-Bertholet
changed the title
Jules-Bertholet
force-pushed
the
locks-break-latches
branch
from
7c82bb5 to
801c873
Compare
Jules-Bertholet
force-pushed
the
locks-break-latches
branch
3 times, most recently
from
0e7cb15 to
03ef230
Compare
Changed latching behavior so that latching a modifier or group now breaks existing modifier latches, but only if the type of the key responsible for the latter latch has the modifier of the pre-existing latch in its modifiers list. For example, if a new latch is triggered by pressing a key of type `ALPHABETIC`, existing `Shift` and `Lock` latches will now be broken, but other latches will be preserved as before. This ensures the correct behavior when combining sticky keys with `ISO_Level5_Latch` or latched-group additional symbols layers. Signed-off-by: Jules Bertholet <[email protected]>
Jules-Bertholet
force-pushed
the
locks-break-latches
branch
from
03ef230 to
cf08189
Compare
Prior to this commit, "latch A down" → "latch B down" → "latch A up" → "latch B up" would result in only B being latched. After this commit, both A and B end up latched. Signed-off-by: Jules Bertholet <[email protected]>
Jules-Bertholet
changed the title
Signed-off-by: Jules Bertholet <[email protected]>
Signed-off-by: Jules Bertholet <[email protected]>
Jules-Bertholet
force-pushed
the
locks-break-latches
branch
from
dc4277e to
eac392e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any new lock breaks all existing latches
For example, if
Caps_Lockis on the second level of some key, andShiftis latched, pressing the key will enableCapswhile also breaking theShiftlatch, ensuring that the next character is properly uppercase. (Prior to this commit, bothShiftandCapswould be active, so the next character would be lowercase.) (Setting a lock vialatchToLockor clearing it viaclearLocksalso breaks all latches.)New latches break existing latches for non-
preserved modifiers in the modifier list of the type of the key that triggered the new latchFor example, if a new latch is triggered by pressing a key of type
ALPHABETIC, existingShiftandLocklatches will now be broken, but other latches will be preserved as before.This ensures the correct behavior when combining sticky keys with
ISO_Level5_Latchor latched-group additional symbols layers.The rules for what does and does not break a latch are also applied before the latch is formed
Notably, pressing two latching keys simultaneously now applies both latches. For example, if I set up sticky keys, and then press
ShiftandAltGrtogether, both modifiers now end up latched.An alternative to #51 that resolves its motivating issue without incurring the problems discussed in the comments there.