Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again doing a few things at once that you likely would want to breakup just to spark the discussion:
Splits Paginator into two classes:
page
(with cursor),records
(just the records),page_info
(metadata),total
Some other changes:
records
andpage_info
from the Page class on a public method on Paginator - addressing: Option to get plain paginated records directly #1filter_values
which is no longer used since this PR: https://github.com/xing/rails_cursor_pagination/pull/7/filesOf course this is more a draft - no added specs etc.
But I think a few benefits of this approach is to help reduce the class size; help clean up the specs (which right now are all testing the full paginator class and hence tests that should be fast - like validators, still take a lot of setup time)