Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to LoadSupport #3805

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Improvements to LoadSupport #3805

wants to merge 2 commits into from

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Oct 9, 2024

Still very much a WIP based on convos with Greg and Lee

Thinking about whether as part of this we want to allow passing loadSpec explicitly to ExceptionHandlerOptions.

Might make it easier for implementations to just pass the loadSpec and know that Hoist will make the right decision about showing the alert (e.g. not for obsolete, auto-refresh)

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler requested a review from ghsolomon October 9, 2024 18:43
@lbwexler lbwexler changed the title Checkpoint Improvements to LoadSupport Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant