Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GridModel hideGroupedColumns and showUngroupedColumns config #2963

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

petradish
Copy link
Contributor

Resolves #1369

  • This was a lot trickier than I already expected. Needs more work/consideration.
  • Setting the ag-grid flag suppressMakeColumnVisibleAfterUnGroup= true seems like the best way to allow us to control column visibility.
  • There is a degenerate case where the combination of hideGroupedColumns = true && showUngroupedColumns = false can permanently hide a column with excludeFromChooser = true && hidden = false. I added a warning for this case -- not sure what else to do there.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • [N/A] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@petradish petradish requested review from lbwexler and amcclain April 19, 2022 23:28
@amcclain amcclain self-assigned this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GridModel should have a 'hideGroupByCols' option
2 participants