Hoist dialog model #1714

cnrudd · 2020-02-25T20:50:16Z

WIP.
This PR is for Hoist React ticket #861 .

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

Caught up with develop branch as of last change.
Added CHANGELOG entry, or determined not required.
Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
Updated doc comments / prop-types, or determined not required.
Reviewed and tested on Mobile, or determined not required.
Created Toolbox branch: https://github.com/xh/toolbox/tree/hoistDialogModel PR: Hoist dialog model toolbox#367

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

…ing to chrome v79 fixed the issue.

+ Fix css for for handle cursor + Cannot create a default model since a model is needed to show() dialog.

…display:flex

…rt just one dim if resizable = false;

# Conflicts: # yarn.lock

…ogModel # Conflicts: # yarn.lock

+ Javascript Tweaks, plus Hoist conventions for props de-referencing + Split out implementation components + Remove extraneous method + Initial Commenting

+ Simplify Z-Index API for now + Remove support for overriding certain event handlers in rndOptions + Minor cleanups

cnrudd added 30 commits December 26, 2019 16:02

First cut of hoist dialog with isDraggable option.

471594f

Removed unused imports.

7da244f

Added canMaskClickClose prop and maskClick handler

2bab03f

Fix maskclick handler

8a90e0f

added todo

ec01ac3

Support autoFocus: true on dialog children

73ccc65

Replaced react-draggable with react-rnd, which uses react-draggable.

107c490

Added --xh-dialog-box-shadow

90f5f42

Support for resizing

d6650a3

Fix repaint bug

9a7f05b

Remove redundant use of splitLayoutProps

b3fe561

Remove bug comment and fix. Bug existed only on chrome 78.3x . Upgrad…

2a65a78

…ing to chrome v79 fixed the issue.

Refactored with elementfactory.

c8f401b

Remove need for constructor.

8e347e3

Converted Dialog from class comp to function comp.

3af10ed

Support resizable config

a3b640b

Refactor, with dialogHeader impl

d583d76

Linting.

fad1660

Let dialogs autocenter based on content dimensions;

88b0d45

+ Fix css for for handle cursor + Cannot create a default model since a model is needed to show() dialog.

Use given width and height props if resizeable

c06514e

throw if no dims props with resizable = true

42a4d00

Add Maximize Minimize toggle if resizable.

d7d7a10

Implemented localstorage statemodel on dialog.

41c129c

Improve handling of 0 position values.

cfaa2af

Improve safe state loading on dialog.

e3169c1

Remove unnecessary setting of defaults on RnD, fix unMaximize.

1d57410

Support x, y props.

21f9f5d

Merge branch 'develop' into hoistDialog

10f08c2

Merge branch 'develop' into hoistDialog

40c27b5

Cleanup setState on render logic

28c1175

cnrudd and others added 28 commits March 4, 2020 14:32

Merge branch 'develop' into hoistDialogModel

95a5217

Better use of computed and observables for position and sizing.

d8d7f2b

Fix some state model edge cases.

5e75e54

Working observables!

bd54225

Make maximized dialog resize with body when body resizes.

026ce7e

Merge branch 'develop' into hoistDialogModel

3a44217

Fix maximize in non-portal dialog

c4a5aec

Use initialX|Y|Width|Height

4d8fca3

Use currentHeight|Width in sizing dialog content

014ef1e

Refactor pos and size functionality.

9ccb92f

Enforce x,y & width,height set together.

e2f315b

Prevent draghandles when maximized

86075b2

todo reminder

378b189

Name cleanups.

7c7efde

Move non-public methods to implementation section.

5e60c71

Replace .bp3_dailog default css width of 500px with content width

405df39

Put width setting on content, not on dialog.

35c2d6f

Specify width on ClientError dialog, and make resizable.

c6a1596

Better content rendering via css: avoid background -color bleed with …

b127522

…display:flex

Now that dialog is resizable, make jsoninput 100% height

91d1537

Put width spec on Dialog, not on content.

36c2520

New MenuButton component

62f631d

Support resizable with no width & height, or just one dim. Also suppo…

e99536a

…rt just one dim if resizable = false;

Merge branch 'develop' into hoistDialogModel

46ee943

# Conflicts: # yarn.lock

Merge remote-tracking branch 'origin/hoistDialogModel' into hoistDial…

c163282

…ogModel # Conflicts: # yarn.lock

+ Pass model with Context.

5492d18

+ Javascript Tweaks, plus Hoist conventions for props de-referencing + Split out implementation components + Remove extraneous method + Initial Commenting

+ Use LocalModel pattern

76883e7

+ Simplify Z-Index API for now + Remove support for overriding certain event handlers in rndOptions + Minor cleanups

Rework of menubutton to splitbutton

8221aa1

lbwexler closed this Mar 30, 2020

lbwexler deleted the hoistDialogModel branch April 29, 2020 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hoist dialog model #1714

Hoist dialog model #1714

cnrudd commented Feb 25, 2020 •

edited

Loading

Hoist dialog model #1714

Hoist dialog model #1714

Conversation

cnrudd commented Feb 25, 2020 • edited Loading

Hoist P/R Checklist

cnrudd commented Feb 25, 2020 •

edited

Loading