New ViewService + Fix bug with memory monitoring #428
Conversation
| @@ -176,6 +176,11 @@ class XhController extends BaseController { | |||
| renderJSON(ret.formatForClient()) | |||
| } | |||
|
|
|||
| def findJsonBlob(String type, String name) { | |||
| def ret = jsonBlobService.find(type, name) | |||
| renderJSON(ret?.formatForClient()) | |||
There was a problem hiding this comment.
Curious if it would be appropriate to return a 404 if we can't find the requested blob
There was a problem hiding this comment.
Also realized this only returns a blob if it is owned by the user, whereas the listJsonBlobs endpoints returns blobs for which the user passesAcl. I see why you did this, but I wonder if it could be confusing-- i.e. "Why do I see a blob in the list of all blobs, but when I try to look it up directly using the findJsonBlob endpoint, nothing is returned?"
| } | ||
| return blob | ||
| @Transactional | ||
| JsonBlob createOrUpdate(String type, String name, Map data, String username = username) { |
There was a problem hiding this comment.
Does this work for blobs that are not owned by the authenticated user? In the context of views, blobs describing "Global" views with null owners?
There was a problem hiding this comment.
Here I was definitely mirrorring the create semantics, which only allow you to create a blob that you own. Will comment that better.
There was a problem hiding this comment.
I think I just misunderstood it - looks good to me :)
lbwexler
changed the title
lbwexler
changed the title
No description provided.