Add Go modules support #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's a good practice to separate those from the main package for the other people to use them on their own
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked in #42 I separated module-related changes from the linter fixes.
Now people will be able to just do
go get github.com/xeals/signal-back(or add@latest,@v0.2.0) like the old times (starting with Go 1.12) and get the required binary release with proper dependencies.By design repo should now also tag the
signal/vX.Y.Zreleases of thesignalautogenerated submodule, so that other people could use it without dragging the whole binary with it.This will in turn allow doing
go get github.com/xeals/signal-back/signal(or with version suffix like with the binary).If this gets merged, I suggest tagging the merge commit with 2 tags:
v0.2.0for the repo itselfsignal/v0.1.0for the submodule