Tutorial planned improvements to parsing #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given XDP is very performance focused, it is unwise to default parse many VLAN layers. Those 2 as it is very uncommon to have more. Signed-off-by: Jesper Dangaard Brouer <[email protected]>
Signed-off-by: Jesper Dangaard Brouer <[email protected]>
This is based on same function from packet-solutions/xdp_vlan02_kern.c that also extracts VLANs. It needs to be removed from packet-solutions/xdp_vlan02_kern.c, but for now its just ifdef defined out-of-code. Need to run some tests and look at BPF byte-code to make sure it does the right thing. The original parse_ethhdr() is implemented by calling parse_ethhdr_vlan() with NULL argument for stucture to collect IDs into. The compiler should remove the parts that are not needed. Signed-off-by: Jesper Dangaard Brouer <[email protected]>
|
Hmmm... why does this PR also contain libbpf changes??? Perhaps, this is why I had funny issues in #72, they could likely happen when I was switching between branches? |
|
Guess you accidentally did a 'git add libbpf' somewhere? :) |
|
PR #168 is taking over from this PR. |
netoptimizer
added a commit
that referenced
this pull request
Nov 15, 2020
…ebase01.public Tutorial improve parsing of VLANs (rebased #73)
|
Fixed in #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to LPC2019 very soon...
I didn't finish this work, so I'll just store the branch and create a PR so I don't forget about this ;-)
I'm not quite ready to merge this, as I've not tested it and even convinced myself this is a good idea.