Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.themoviedb.helper] 5.2.25 #4526

Open
wants to merge 1 commit into
base: nexus
Choose a base branch
from

Conversation

jurialmunkey
Copy link

Description

Add and update TMDbHelper for Nexus and higher.

NOTE
Requires script.module.jurialmunkey to be updated in this PR first to meet dep requirements: xbmc/repo-scripts#2624

Acts as a helper plugin to generate widgets and retrieve details from online APIs for skinners. See wiki for full feature list
https://github.com/jurialmunkey/plugin.video.themoviedb.helper/wiki

Note an older version exists on Matrix repo. However, I'm submitting new for Nexus as the current version now uses the new infotag setters and so now only works on Nexus or higher.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@jurialmunkey
Copy link
Author

jurialmunkey commented Jun 8, 2024

packaging.version.InvalidVersion: Invalid version: '5.2.25~nexus'

I don't understand this error? This is a valid version afaik.
Is the tilde ~ not allowed in the repo?

EDIT: I've removed the ~nexus suffix so the checker doesn't complain.

@jurialmunkey jurialmunkey force-pushed the nexus.plugin.video.themoviedb.helper branch 2 times, most recently from 28a380b to daa002a Compare June 8, 2024 03:14
@jurialmunkey
Copy link
Author

I've fixed all the errors. Checker is still complaining because of the dependency module that needs to go in first but otherwise should be clean now.

@Hitcher
Copy link

Hitcher commented Jun 15, 2024

Does the addon checker need running again for this (and script.skinvariables) now that script.module.jurialmunkey v0.1.18 has been committed?

@jurialmunkey jurialmunkey force-pushed the nexus.plugin.video.themoviedb.helper branch from daa002a to 0b08385 Compare June 16, 2024 01:23
@jurialmunkey
Copy link
Author

Does the addon checker need running again for this (and script.skinvariables) now that script.module.jurialmunkey v0.1.18 has been committed?

Yeah, it looks like Bas tried yesterday but it hadn't quite hit the repo yet so still failed. I just retriggered now by force pushing a blank commit amend and looks like green light now.

@kris06
Copy link

kris06 commented Jun 20, 2024

major problem on search, 'the accents are not supported' on Fuse

Example
(en francais) présumé innocent is invalid
presumed innocent is valid research

@Hitcher
Copy link

Hitcher commented Jun 20, 2024

@kris06 this isn't the correct place for issues. Please go here instead: https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants