Draft: Decaffeinate & drop Ruby, get CI running again #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a shot at #372, and this is the result of that. I applied decaffeinate and brought the whole build system to a working state again. From my limited testing on my local Kodi box and through the BrowserSync devmode everything seems to be working fine. This should bring us in a position where it is easier to move the project forward.
This port still needs to be followed-up by a cleanup pass over all the converted files, removing the TODO comments when done. Also, eco still uses coffeescript for the jst files.
The JS source code also still uses globals and no
import/export, thecoffeecompile task was replaced by a simpleconcat. Eventually, this could be replaced by a proper bundler like esbuild / webpack.To get the scss build working again, I replaced Ruby Sass by Dart Sass. The sass dependencies are now loaded via npm, I looked for equivalent replacements for the used packages and so far they are working out. (In hindsight it would have been easier to do this before transforming the coffeescript files)
Any thoughts on the direction this is taking?