Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove & ignore generated files #573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Jan 29, 2024

Those files are generated during the build process.
Therefore they shouldn't be tracked.

@Rechi Rechi requested a review from enen92 January 29, 2024 10:58
Copy link
Contributor

@malard malard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure how this works to not commit these back in to the repo? We need these generated files to create the actual files that will be used in a release and also to push into xbmc/xbmc ?

Those files are generated during the build process.
Therefore they shouldn't be tracked.
@Rechi
Copy link
Member Author

Rechi commented Feb 16, 2024

The files are added to the .gitignore file, so they aren't listed as untracked files by git status or gui tools.
Yes those files are required in a release, but those are generated during the build process.

Currently there is the situation, that those files don't match the actual state of the input source files for a specific commit. Contributors could think they've to update both files (source and generated).

@malard
Copy link
Contributor

malard commented Feb 16, 2024

So are you saying that we need to delete the existing files in the repo also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants