-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made compatible with 'Arrow' 0.14.5 #142
base: master
Are you sure you want to change the base?
Conversation
Verified from #141 having implemented manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified fix. 👍
This works, though I did have to install
|
why is this still merged? No active user has write access to the repo any more? |
I now have a replacement written from scratch: ellygaytor/trasheddit |
Can we merge these in? |
It seems like all the contributors have gone inactive. Your message inspired me to message the creator on linkedin. I think everyone ends up at this specific repository because of search engines so I'd love to see this version get updated instead of everyone forking and duplicating effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!important
The latest version of the Arrow library removed the deprecated functionality to use replace() with plural parameters. Calls like that should instead use shift(), which this patch does in order to restore functionality of the Shreddit script.