Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluginzie Persisted Operations with provided client info #1288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janeli1
Copy link

@janeli1 janeli1 commented Oct 18, 2024

Motivation and Context

This change is to implement the feature requested in #1278 by:

  1. Expose Persisted Operations Client interface in pkg directory
  2. Refactor ClientInfo struct into pkg/client interface and allow providing customized client info which can be used as inputs for FetchPersistedOperations

Copy link

github-actions bot commented Nov 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 2, 2024
@StarpTech
Copy link
Contributor

HI @janeli1, due to the refactor in #1330 I think this PR will be become obsolete. @df-wg can based on your findings add a test case to ensure that this has been addressed.

@janeli1
Copy link
Author

janeli1 commented Nov 4, 2024

HI @janeli1, due to the refactor in #1330 I think this PR will be become obsolete. @df-wg can based on your findings add a test case to ensure that this has been addressed.

Hi, May I know how to use APQ to allow providing customized client info which can be used as keys for FetchPersistedOperations? In our use case, querying PO is not only based on PO hash, but also other information, such as app version, app name, etc.

@StarpTech
Copy link
Contributor

@janeli1 my bad, the comment was intended for #1286

@github-actions github-actions bot removed the Stale label Nov 5, 2024
Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants