chore(RFC): custom metric module system #1125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
StarpTech
requested changes
Sep 15, 2024
| MetricOperationPostExecuteHook | ||
| } | ||
|
|
||
| type MetricOperationHook interface { |
There was a problem hiding this comment.
What was your motivation to create a different abstraction of hooks just for metrics? Wouldn't it be easier and more consistent, if a developer can just leverage the standard hooks to implement custom metrics?
In my opinion, creating a second hook system just for metrics isn't needed.
| @@ -0,0 +1,196 @@ | |||
| --- | |||
There was a problem hiding this comment.
Is this RFC still valid? You already addressing custom metrics support in your other RFC.
There was a problem hiding this comment.
Let me close this one and we'll just use the other RFC.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This RFC proposes a custom metric module system that allows pluggable modules for metrics, tracing, schema usage, logging, and more. The design of the metric module system is directionally aligned with the core module system design. However, it exposes visitor pattern-like hooks for every event point in the router lifecycle, providing full control. Additionally, it offers logically grouped interfaces for simpler integrations.
Ideally, we want the core module system to expose a superset of hooks of the proposed ones and metrics module can be directly plugin to the core system module. Open for discussion.
TODO