Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a post authenticaton handler to validate email domain during federated authentication #6177

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Dec 4, 2024

Proposed changes in this pull request

This pr introduces a new post authentication handler to validate the email address of the user authenticated from a federated IDP.

This handler will be invoked when email domain based organization discovery is enabled to prevent user authentication and provisioning to organizations when the authenticated user's email domain does not match with any of the mapped email domains for the organization.

Related issue

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 53.38346% with 62 lines in your changes missing coverage. Please review.

Project coverage is 41.05%. Comparing base (05ca9b4) to head (f5cda0f).
Report is 234 commits behind head on master.

Files with missing lines Patch % Lines
...ler/request/impl/EmailDomainValidationHandler.java 53.57% 27 Missing and 12 partials ⚠️
.../authentication/framework/util/FrameworkUtils.java 55.17% 9 Missing and 4 partials ⚠️
.../framework/internal/FrameworkServiceComponent.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6177      +/-   ##
============================================
+ Coverage     40.51%   41.05%   +0.53%     
- Complexity    15179    15520     +341     
============================================
  Files          1781     1797      +16     
  Lines        122678   123955    +1277     
  Branches      21077    21703     +626     
============================================
+ Hits          49709    50887    +1178     
- Misses        65505    65535      +30     
- Partials       7464     7533      +69     
Flag Coverage Δ
unit 27.75% <53.38%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yasasr1 Yasasr1 force-pushed the add-email-domain-validatioh branch 2 times, most recently from b25fbc7 to f2d9736 Compare December 6, 2024 08:04
@Yasasr1 Yasasr1 force-pushed the add-email-domain-validatioh branch from f2d9736 to f5cda0f Compare December 6, 2024 09:29
Copy link

sonarqubecloud bot commented Dec 6, 2024

@Yasasr1 Yasasr1 changed the title Add a post authenticaton handler to validation email domain during federated authentication Add a post authenticaton handler to validate email domain during federated authentication Dec 6, 2024
@Yasasr1 Yasasr1 marked this pull request as draft December 13, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant