Allow for Configurable Shallow-Render Depth #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapaStef
changed the title
RobvH
reviewed
Aug 20, 2017
| return mount(c, ...args) | ||
| } | ||
|
|
||
| function shallowRenderComponents (component) { | ||
| function shallowRenderComponents (component, depth) { |
There was a problem hiding this comment.
This is awesome!
Thinking about it as a whole, now that depth is definable, is this still the best name for the method? shallow is now only a default depth. This seems to have become renderComponents
There was a problem hiding this comment.
Or renderComponentsByDepth... something along those lines. Although, I don't mind the shallowRender name since we are still shallowRendering with added control on how shallow.
AndersonZacharyT
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more info, please see Issue #11