Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Units class from Elevator and Arm Feedforwards #7570

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove Units class from Elevator and Arm Feedforwards #7570

wants to merge 6 commits into from
+26 −110

Conversation

narmstro2020
Copy link
Contributor

PR #7489 replace usage of the units library with calculateWithVelocities.

This does the same for ElevatorFeedforward and ArmFeedforward

@narmstro2020 narmstro2020 requested a review from a team as a code owner December 21, 2024 19:08
@github-actions github-actions bot added the component: wpimath Math library label Dec 21, 2024
@narmstro2020
Copy link
Contributor Author

/format

@ThadHouse
Copy link
Member

/format doesn't work anymore. You'll need to manually fix up the formatting.

@narmstro2020
Copy link
Contributor Author

/format doesn't work anymore. You'll need to manually fix up the formatting.

aw that's sad :(

@narmstro2020 narmstro2020 requested a review from a team as a code owner December 21, 2024 20:39
@narmstro2020
Copy link
Contributor Author

I think this one is ready for checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
component: examples component: wpimath Math library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narmstro2020 @ThadHouse @calcmogul