-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app icons on Windows #7116
Fix app icons on Windows #7116
Conversation
It came from https://github.com/wpilibsuite/branding, so the export process should get fixed upstream. |
The icons for the other tools seem to be generated completely differently compared to the way the branding repo does things. In particular, |
Are you sure? The source file isn't in the branding repo. That only has the WPILIB logo, not the various tools logos. My recollection is all the tools ones were done differently, which seems to match what @Gold856 found. |
If there are transparency issues with the other icons, can you please fix those up too? Can be in a separate PR. It sounds like the PNGs themselves are fine, it's just the .ico file that is incorrect? |
Yeah, the PNGs are fine, the .ico files are inconsistent/incorrect. |
This comment was marked as outdated.
This comment was marked as outdated.
The Windows build is failing with a RC1011 error. |
a51588d
to
be6b80f
Compare
The SysId icon has a bunch of weird artifacting and it's not transparent on Windows. Some of the other icons have issues as well and all of them are inconsistent. GIMP was used to regenerate all the icons from the PNGs, using PNG compression on all the layers.