Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app icons on Windows #7116

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix app icons on Windows #7116

merged 1 commit into from
Sep 23, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Sep 22, 2024

The SysId icon has a bunch of weird artifacting and it's not transparent on Windows. Some of the other icons have issues as well and all of them are inconsistent. GIMP was used to regenerate all the icons from the PNGs, using PNG compression on all the layers.

@Gold856 Gold856 requested a review from a team as a code owner September 22, 2024 05:27
@Gold856 Gold856 marked this pull request as draft September 22, 2024 05:33
@Gold856 Gold856 marked this pull request as ready for review September 22, 2024 05:54
@calcmogul
Copy link
Member

It came from https://github.com/wpilibsuite/branding, so the export process should get fixed upstream.

@Gold856
Copy link
Contributor Author

Gold856 commented Sep 22, 2024

The icons for the other tools seem to be generated completely differently compared to the way the branding repo does things. In particular, -define icon:auto-resize seems to not be used in favor of just specifying all the PNGs. The icons aren't even consistent in size either. Some max out at 256x256, while others go to 512x512 (seems to be Glass and OutlineViewer). Weirdly enough, Glass and OutlineViewer also have transparency issues with the smaller resolutions.

@sciencewhiz
Copy link
Contributor

It came from https://github.com/wpilibsuite/branding, so the export process should get fixed upstream.

Are you sure? The source file isn't in the branding repo. That only has the WPILIB logo, not the various tools logos. My recollection is all the tools ones were done differently, which seems to match what @Gold856 found.

@PeterJohnson
Copy link
Member

If there are transparency issues with the other icons, can you please fix those up too? Can be in a separate PR. It sounds like the PNGs themselves are fine, it's just the .ico file that is incorrect?

@Gold856
Copy link
Contributor Author

Gold856 commented Sep 23, 2024

Yeah, the PNGs are fine, the .ico files are inconsistent/incorrect.

@Gold856 Gold856 changed the title [sysid] Fix icon Fix app icons on Windows Sep 23, 2024
@Gold856

This comment was marked as outdated.

@PeterJohnson
Copy link
Member

The Windows build is failing with a RC1011 error.

@Gold856 Gold856 force-pushed the sysid-icon branch 3 times, most recently from a51588d to be6b80f Compare September 23, 2024 05:44
@PeterJohnson PeterJohnson merged commit 22f086a into wpilibsuite:main Sep 23, 2024
33 checks passed
@Gold856 Gold856 deleted the sysid-icon branch September 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants